From 3c36efb7ea5dd8cccd9bcc47f4f6e71ee4cfcbb2 Mon Sep 17 00:00:00 2001 From: Marlon Schumacher <schumacher@hfm-karlsruhe.de> Date: Wed, 05 Mar 2025 23:03:24 +0100 Subject: [PATCH] chore: more linting for sox-hoaencode class --- sources/sox-process.lisp | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/sources/sox-process.lisp b/sources/sox-process.lisp index df6ea1c..9fbae0d 100644 --- a/sources/sox-process.lisp +++ b/sources/sox-process.lisp @@ -186,8 +186,7 @@ ; (consider how to deal with multiple sounds to be hoaencoded and mixed later on... sox-mix might be better done in an explicit way rather than via the class directly. ; in that case a 3DC would have to be used by using points (point-pairs) in a loop - (if (probe-file *sox-path*) - (progn + (if (probe-file *sox-path*) (let ((sound (sound sox-input))) (when (and (stringp sound) (equal output "pipe")) @@ -202,13 +201,14 @@ ; case: order = 0 (setf str (string+ str (format nil " ~s" filename))) ; case: order > 0 - (progn ; here it would be more redundant to call sox-merge with the given params + (progn ; it is impossible to create a sox-merge instance as gain values are in dB which cannot represent negative amplitudes + (setf str (string+ str " -M")) - (loop for gain in (sox-hoaencode-gains-up-to-order (order sox-input) (azimuth sox-input) (elevation sox-input)) + (loop for gain in (print (sox-hoaencode-gains-up-to-order (order sox-input) (azimuth sox-input) (elevation sox-input))) do (setf str (string+ str (format nil " -v~d ~s" gain filename)))) ) ) - ; ) + ) (setf str (cond @@ -219,6 +219,7 @@ (t (sox-samplebits str bitdepth samplerate outfile)) ) ) + (setf str (string+ str sox-effect)) (print str) (sox-out str sox-input output outfile recursive) @@ -228,12 +229,11 @@ ; (when *delete-inter-file* (clean-tmp-files)) ) - ) - ) (sox-not-found) ) ) + ; === sox-mix ============= (defmethod! sox-process ((sox-input sox-mix) (sox-effect string) &key output filetype samplerate bitdepth recursive batch-mode) -- Gitblit v1.9.1